TSPS-405 Add quota units to quota info response #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorgantaylor
commented
Feb 26, 2025
| @@ -173,7 +173,7 @@ def _exchange_code_for_response( | |||
| if "error" in json_response: | |||
| # see https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow#error-response-1 | |||
| LOGGER.debug( | |||
| f"Error in authentication flow exchanging code for response: {json_response["error"]}; error description: {json_response["error_description"]}" | |||
| f'Error in authentication flow exchanging code for response: {json_response["error"]}; error description: {json_response["error_description"]}' | |||
There was a problem hiding this comment.
unrelated to this PR, but this will fix the issue George saw previously
There was a problem hiding this comment.
do we know what was causing this to be an "error" ?
There was a problem hiding this comment.
does seem to be a python version thing. this error comes up using python 3.10 but not using python 3.12.
jsotobroad
approved these changes
Feb 26, 2025
| @@ -173,7 +173,7 @@ def _exchange_code_for_response( | |||
| if "error" in json_response: | |||
| # see https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow#error-response-1 | |||
| LOGGER.debug( | |||
| f"Error in authentication flow exchanging code for response: {json_response["error"]}; error description: {json_response["error_description"]}" | |||
| f'Error in authentication flow exchanging code for response: {json_response["error"]}; error description: {json_response["error_description"]}' | |||
There was a problem hiding this comment.
do we know what was causing this to be an "error" ?
Merged
4 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added quota units to be displayed to the user when they request their quota info:
Note tests will fail here until the service PR is merged and this PR has been updated with the new client version.
Jira Ticket
https://broadworkbench.atlassian.net/browse/TSPS-405
Checklist (provide links to changes)
terralab logoutand thenterralab pipelines list)