-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CECO-1729] Installer support #820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a nit with GPG keys and a few questions LGTM overall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a Chef expert; but overall this LGTM! It'd be nice to add DD_REMOTE_POLICIES
support as well (same as DD_REMOTE_UPDATES
), but let's not block this PR 😄
Thanks a lot for this
What does this PR do?
Adds support for the Datadog installer within Puppet, including a kitchen test
Describe your test plan
Covered by kitchen E2E test and manually tested:
remote_updates
with the value you set