Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CECO-1729] Installer support #820

Merged
merged 4 commits into from
Nov 27, 2024
Merged

[CECO-1729] Installer support #820

merged 4 commits into from
Nov 27, 2024

Conversation

tbavelier
Copy link
Member

What does this PR do?

Adds support for the Datadog installer within Puppet, including a kitchen test

Describe your test plan

Covered by kitchen E2E test and manually tested:

  1. Run a Ubuntu vm as part of a Puppet cluster as agent
  2. Install the installer using the following node manifest:
class { "datadog_agent":
  api_key => "REPLACE_ME",
  datadog_installer_enabled => true,
  apm_instrumentation_enabled => "host",
  apm_instrumentation_libraries => ["java:1", "python:2"],
  remote_updates => "true",
  log_level => "debug",
  agent_extra_options => {
    hostname_trust_uts_namespace => true,
  },
}
  1. Ensure the installer is installed and that it added your desired packages:
/usr/bin/datadog-installer is-installed datadog-apm-library-java
# should exit code 0
/usr/bin/datadog-installer is-installed datadog-apm-library-python
# should exit code 0
/usr/bin/datadog-installer is-installed datadog-agent
# should exit code 0 if remote_updates is true, 10 otherwise
  1. Verify the Agent config file is correct, includes your additional options, remote_updates with the value you set

@tbavelier tbavelier requested review from a team as code owners November 12, 2024 09:21
Copy link
Contributor

@Pythyu Pythyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a nit with GPG keys and a few questions LGTM overall

Copy link
Contributor

@Pythyu Pythyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

@BaptisteFoy BaptisteFoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a Chef expert; but overall this LGTM! It'd be nice to add DD_REMOTE_POLICIES support as well (same as DD_REMOTE_UPDATES), but let's not block this PR 😄

Thanks a lot for this

@tbavelier tbavelier merged commit da74780 into main Nov 27, 2024
35 checks passed
@tbavelier tbavelier deleted the tbavelier/datadog_installer branch November 27, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants