Merge pull request #11 from Dataport/refactor/improve-pins-readability

refactor pins module code for readability
Dataport · Nov 14, 2023 · c9f30da · c9f30da
2 parents 44d58f9 + 8f16417
commit c9f30da
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/packages/plugins/Pins/src/store/index.ts b/packages/plugins/Pins/src/store/index.ts
@@ -160,22 +160,18 @@ const storeModule: PolarModule<PinsState, PinsState> = {
           //      implementations ... missing abstract method?
           // eslint-disable-next-line @typescript-eslint/ban-ts-comment
           // @ts-ignore
-          const coordinatesAfterDrag = geometry?.getCoordinates()
+          let coordinates = geometry?.getCoordinates()
 
-          if (
-            await dispatch('isCoordinateInBoundaryLayer', coordinatesAfterDrag)
-          ) {
-            commit('setCoordinatesAfterDrag', coordinatesAfterDrag)
-            dispatch('updateCoordinates', coordinatesAfterDrag)
-          } else {
+          if (!(await dispatch('isCoordinateInBoundaryLayer', coordinates))) {
+            coordinates = getters.transformedCoordinate
             dispatch('removeMarker')
             dispatch('showMarker', {
-              coordinates: getters.transformedCoordinate,
+              coordinates,
               clicked: true,
             })
-            commit('setCoordinatesAfterDrag', getters.transformedCoordinate)
-            dispatch('updateCoordinates', getters.transformedCoordinate)
           }
+          commit('setCoordinatesAfterDrag', coordinates)
+          dispatch('updateCoordinates', coordinates)
         })
       })
     },