Now checks that api method actually exist!

Decatur-Robotics · Dec 19, 2024 · 3c9f9af · 3c9f9af
1 parent 3994adb
commit 3c9f9af
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/lib/api/ApiLib.ts b/lib/api/ApiLib.ts
@@ -171,7 +171,7 @@ namespace ApiLib {
 	};
 
 	export abstract class ApiTemplate<TDependencies> {
-		[route: string]: any;
+		// [route: string]: any;
 
 		private initSegment(segment: Segment<any>, subUrl: string) {
 			for (const [key, value] of Object.entries(segment)) {
@@ -194,7 +194,7 @@ namespace ApiLib {
 		}
 
 		protected init() {
-			this.initSegment(this as Segment<any>, "");
+			this.initSegment(this as unknown as Segment<any>, "");
 		}
 
 		/**
@@ -232,7 +232,7 @@ namespace ApiLib {
 
 			try {
 				const route = path.reduce(
-					(segment, route) => segment[route],
+					(segment, route) => Object(segment)[route],
 					this.api,
 				) as unknown as Route<any, any, TDependencies, any> | undefined;
 

diff --git a/lib/api/ClientApi.ts b/lib/api/ClientApi.ts
@@ -82,10 +82,6 @@ export default class ClientApi extends ApiLib.ApiTemplate<ApiDependencies> {
 				await db
 			).findObjectById<Team>(CollectionId.Teams, new ObjectId(teamId));
 
-			console.log(
-				`${(await userPromise)?.name} requested to join ${team?.league} ${team?.number}`,
-			);
-
 			if (!team) {
 				return res.error(404, "Team not found");
 			}
@@ -99,8 +95,6 @@ export default class ClientApi extends ApiLib.ApiTemplate<ApiDependencies> {
 				(await userPromise)?._id?.toString(),
 			]);
 
-			console.log("Request is valid!");
-
 			await (
 				await db
 			).updateObjectById(CollectionId.Teams, new ObjectId(teamId), team);
@@ -521,7 +515,6 @@ export default class ClientApi extends ApiLib.ApiTemplate<ApiDependencies> {
 				compId,
 			);
 
-			console.log(result);
 			return res.status(200).send({ result: result });
 		},
 	});

diff --git a/tests/lib/api/ApiLib.test.ts b/tests/lib/api/ApiLib.test.ts
@@ -86,7 +86,7 @@ test(`ApiLib.${ApiLib.ApiTemplate.name}.init: Sets subUrl`, () => {
 	);
 });
 
-test(`ApiLib.${ApiLib.ApiTemplate.prototype.name}.init: Sets caller`, async () => {
+test(`ApiLib.${ApiLib.ApiTemplate.name}.init: Sets caller`, async () => {
 	expect(clientApi.segment.routeWithPresetCaller.call).toBeDefined();
 });
-Original file line number
+Diff line change
@@ Expand Up @@
     	);
     });
-    test(`ApiLib.${ApiLib.ApiTemplate.prototype.name}.init: Sets caller`, async () => {
+    test(`ApiLib.${ApiLib.ApiTemplate.name}.init: Sets caller`, async () => {
     	expect(clientApi.segment.routeWithPresetCaller.call).toBeDefined();
     });
@@ Expand Down @@