Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DIPU] Check SupportedDiopiFunctions.txt and upgrade to clang17 #633

Merged
merged 8 commits into from
Jan 30, 2024
Merged

[DIPU] Check SupportedDiopiFunctions.txt and upgrade to clang17 #633

merged 8 commits into from
Jan 30, 2024

Conversation

wiryls
Copy link
Collaborator

@wiryls wiryls commented Jan 15, 2024 •
edited
Loading

  • 在 CI 流程中检查大家是否忘记提交自己的 SupportedDiopiFunctions.txt 文件
    • 已测试 SupportedDiopiFunctions.txt 不一致时会正常报错
  • 试了一下 clang17，这个版本新增了缺少或者多余的头文件的检查（iwyu），挺实用的
    • 目前 clang16 到 clang17 不需要修改代码，我把新增的检查都关了，之后逐渐开放吧
  • 顺便优化了一下之前的脚本
    • 移除 subshell
    • 简化部分写法
    • 顺便吐槽一下 git 版本太老了，甚至不支持 -C 之类的参数

@wiryls wiryls added enhancement New feature or request DIPU DIPU related labels Jan 15, 2024
@wiryls wiryls marked this pull request as ready for review January 15, 2024 14:43
@wiryls wiryls requested review from lljbash and fandaoyi January 15, 2024 14:43
lljbash
lljbash approved these changes Jan 16, 2024
View reviewed changes
@wiryls wiryls marked this pull request as draft January 16, 2024 11:05
NeosZhang pushed a commit to DeepLink-org/deeplink.framework.dev that referenced this pull request Jan 18, 2024
@yewentao256
optimize: directly call cudnn conv2d (DeepLink-org#633)
868c564 
* optimize: directly call cudnn conv2d

* add check and remove inline function
@wiryls wiryls marked this pull request as ready for review January 28, 2024 12:22
@wiryls wiryls requested a review from lljbash January 28, 2024 12:22
@wiryls wiryls changed the title [DIPU] Check SupportedDiopiFunctions.txt [DIPU] Check SupportedDiopiFunctions.txt and upgrade to clang17 Jan 30, 2024
fandaoyi
fandaoyi reviewed Jan 30, 2024
View reviewed changes
dipu/scripts/ci/nv/ci_nv_tidy.sh
export PATH=/mnt/cache/share/platform/dep/clang-16/bin${PATH:+:$PATH}
[ -d /mnt/cache/share/platform/env/miniconda3.10/envs/pt2.0_diopi/lib ] &&
export LD_LIBRARY_PATH=/mnt/cache/share/platform/env/miniconda3.10/envs/pt2.0_diopi/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
git -c advice.detachedHead=false clone --depth 1 -b v0.1.2 https://github.com/lljbash/clangd-tidy.git "$self/clangd-tidy"
Copy link
Collaborator

@fandaoyi fandaoyi Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把凌劼这个 项目 fork到 deeplink 里吧。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有道理

@mrdanielw mrdanielw merged commit c61f4cf into DeepLink-org:main Jan 30, 2024
24 checks passed
@mrdanielw mrdanielw deleted the refactor/w/ci branch January 30, 2024 06:41
jinminxi104 added a commit to jinminxi104/deeplink.framework that referenced this pull request Jan 31, 2024
@jinminxi104
Revert "[DIPU] Check SupportedDiopiFunctions.txt and upgrade to clang…
a0b6022 
…17 (DeepLink-org#633)"

This reverts commit c61f4cf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fandaoyi fandaoyi fandaoyi left review comments

@lljbash lljbash lljbash approved these changes

@wugeshui wugeshui wugeshui approved these changes

@mrdanielw mrdanielw Awaiting requested review from mrdanielw mrdanielw is a code owner

Assignees
No one assigned
Labels
DIPU DIPU related enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wiryls @lljbash @fandaoyi @wugeshui @mrdanielw