feat(dipu): add schema: ones/zeros/zero_ #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fandaoyi
approved these changes
Mar 26, 2024
lljbash
approved these changes
Mar 26, 2024
| custom_code_at_the_beginning: | | ||
| c10::TensorOptions option; | ||
| auto shape = c10::asIntArrayRefUnchecked(size); | ||
| auto out = nodispatch::empty(shape, option.dtype(dtype).layout(layout).device(device).pinned_memory(pin_memory)); |
There was a problem hiding this comment.
tensoroption 没有给这些方法写右值版本，每次都要 copy 一个 option，不知道这里有没有抠性能的必要？
或许我应该给 empty 补几个重载
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ones/zeros/zero_ op
before:
after:
