Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fdy/fix ascendspeed #744

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Conversation

fandaoyi
Copy link
Collaborator

fix ascend speed 运行中 遇到的 一些问题。 其中 coalse 为临时方案


cleanup()


if __name__ == "__main__":
n_gpus = torch.cuda.device_count()
# world_size = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释是什么情况?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无用的, 我删掉了



def _wrap_new_group(
ranks=None, timeout=default_pg_timeout, backend=None, pg_options=None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能不能加上 typing,其他地方也是

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和 pytorch 现有的保持一致的。它有的我们都加了, 没有的暂时 follow吧。

@fandaoyi fandaoyi merged commit d86ed2f into DeepLink-org:main Mar 25, 2024
29 checks passed
xuq7410 pushed a commit to xuq7410/deeplink.framework that referenced this pull request May 23, 2024
* feature: refactor convolution backward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants