-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DIPU] refactor: rewrite AsyncResourcePool #750
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiryls
commented
Mar 26, 2024
auto& pool = *async_mem_pool(); | ||
while (not pool.empty()) { | ||
auto item = pool.pop(); | ||
if (not item) { | ||
std::this_thread::yield(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yield 作用有限,可能得考虑别的方法降低忙等待的开销
|
xuq7410
pushed a commit
to xuq7410/deeplink.framework
that referenced
this pull request
May 23, 2024
delete python relate depandcy Co-authored-by: zhaoguochun1995 <zhaoguochun1995@sensetime.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
正在改动 allocator 代码。由于非常担心大改动 break 掉很多东西,所以先把一些容易理解、修改和优化的部分改掉。本次重写了 AsyncResourcePool,主要包含这些事项: