Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklists Storage and High Value items from Storage Implant, but reduces cost #2286

Merged
merged 12 commits into from
Jan 5, 2025

Conversation

Lyndomen
Copy link
Contributor

@Lyndomen Lyndomen commented Nov 25, 2024

About the PR

Storage items and high value items cant be stored in storage implant, but storage implant is now 4tc.

Why / Balance

hiding steal obj in implant with no witnesses isnt fun rp, just greentext winner. Adds to the flexibility of the item.

Technical details

yaml, touched upsteam files a good chunk

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

no

Changelog

🆑

  • tweak: Storage Implant is now 4 TC but cannot store steal objectives, or anything that has storage in it.

@Lyndomen Lyndomen requested a review from a team as a code owner November 25, 2024 20:58
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Localization Changes any ftl files size/XS Under 16 lines labels Nov 25, 2024
@Lyndomen
Copy link
Contributor Author

#2253

some options

@Lyndomen
Copy link
Contributor Author

also lmk if you think 6tc is fair, honestly might go cheaper to 4 or whateva

@Stop-Signs
Copy link
Contributor

TBH I wouldn't get this anymore, just not worth it. you may consider looking into giving thieves something to compensate for the loss of this tool

@deltanedas
Copy link
Member

being able to say hide your gun for 6 tc isnt worth it compared to just buying another

storage nerf is good

@Lyndomen
Copy link
Contributor Author

4 TC worth?

Resources/Prototypes/Actions/types.yml Show resolved Hide resolved
Resources/Locale/en-US/store/uplink-catalog.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/store/uplink-catalog.ftl Outdated Show resolved Hide resolved
@MilonPL MilonPL added S: Awaiting Changes Do not merge due to requested changes and removed S: Needs Review labels Nov 26, 2024
@Lyndomen
Copy link
Contributor Author

Thanks melon I'm gonna be away from my computer on all my PRs for the next week or so

@Lyndomen
Copy link
Contributor Author

Lyndomen commented Dec 7, 2024

dropped tc cost down to 4

@github-actions github-actions bot added the size/S 16-63 lines label Dec 8, 2024
@github-actions github-actions bot removed the size/XS Under 16 lines label Dec 8, 2024
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@deltanedas deltanedas requested a review from a team as a code owner December 17, 2024 04:52
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Dec 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jink23
Copy link

jink23 commented Dec 22, 2024

So this PR essentially removes the purpose of the storage implant of being a way to 'hide' High value items which was really it's intended purpose and just kinda leads to it being a waste to use outside of just hiding a weapon or two.. overall not a fan

Being caught/losing the High value item because you have no reliable way to store it isn't really 'good RP' either it just leads to people finding more annoying ways to hide it

@beck-thompson
Copy link
Contributor

So this PR essentially removes the purpose of the storage implant of being a way to 'hide' High value items which was really it's intended purpose and just kinda leads to it being a waste to use outside of just hiding a weapon or two.. overall not a fan

I think the issue is that it makes steal objectives basically free and also is basically a forced buy (If your trying to greentext) when you get one. At least for me, whenever I get a steal objective its really really hard not to buy it and it just ends up using so much of my TC. If that's really its intended purpose, it should come free with all steal objectives so you can actually spend TC on stuff that makes the round interesting instead of just thieving gloves and storage implant.

@Lyndomen
Copy link
Contributor Author

Lyndomen commented Jan 5, 2025

bump, direction approved

deltanedas
deltanedas previously approved these changes Jan 5, 2025
@deltanedas deltanedas enabled auto-merge (squash) January 5, 2025 02:30
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 5, 2025
@deltanedas deltanedas merged commit 85a4cc1 into DeltaV-Station:master Jan 5, 2025
14 checks passed
@Lyndomen Lyndomen deleted the storageops branch January 8, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants