-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mercenary outfit to clothesmate #2306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm cc @therealDLondon
Yeah no issues from me, I love the merc outfits. Cant wait for sec to batong the passenger for wearing it |
Took me 17 minutes to remember I have merge perms |
Took me 20 seconds to realise I cant bypass the epic shader troll |
Wouldn't it be better if it was in the costume vendor and not the clothing vendor? |
Honestly not sure, but to be honest I don't think it matters a great deal. |
Any other outfit that isn't general clothing/jumpsuits is usually put into the costume vendor. Plus most people who will be using this will mostly be using it as a costume I wouldn't doubt. |
Can't really say if people are more likely to use it as a costume than a legitimate military outfit, but based on the current inventory the ClothesMate seems like a better fit. ClothesMate has:
AutoDrobe has:
|
Merge Branch Merge Branch Merge Branch Merge Branch (I don't know why this is still failing when it's just 4 lines of yaml but it's driving me crazy). |
Fail says that with your change now a cloth vend restock gives more money than it's worth |
You know that makes a lot of sense, actually. Though I kinda hate to increase the price of the restock even more given it's already 3500$ for something that doesn't have that many benefits. But I guess Cargo shouldn't have a source of free money, so I'll look into changing it. |
It's by 20 spesos, make it cost 50 more and you're good |
Head branch was pushed to by a user without write access
Raised the price by 50$ so it should hopefully pass now. Thanks. |
About the PR
Adds parts of the mercenary outfit (bandana, beret, jumpsuit, fingerless gloves) to the Clothesmate.
Why / Balance
Someone was asking for this, but I also think this is a good idea to add some more variety for appearances. Namely, this would allow passengers to roleplay as mercenaries or other military personnel like colonial marines who are off-duty or on their way to their next deployment.
Technical details
Media
Requirements
Breaking changes
n/a
Changelog
🆑