Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superweapon Safe and spawner #2322

Merged
merged 6 commits into from
Dec 1, 2024

Conversation

Stop-Signs
Copy link
Contributor

@Stop-Signs Stop-Signs commented Nov 30, 2024

About the PR

adds a superweapon safe and groundloot spawner for mappers. it can currently either be the beam devastator or the RPG.
(also fixes a dumb typo I previously made cause im a silly goober)

Why / Balance

I asked @IamVelcroboy about mapping the devastator and he suggested I make this

Technical details

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog

@Stop-Signs Stop-Signs requested a review from a team as a code owner November 30, 2024 00:00
@github-actions github-actions bot added size/S 16-63 lines Changes: YML Changes any yml files S: Needs Review labels Nov 30, 2024
@IamVelcroboy IamVelcroboy self-requested a review November 30, 2024 00:20
@Stop-Signs Stop-Signs changed the title Superweapon Safes Superweapon Safe and spawner Nov 30, 2024
@Stop-Signs Stop-Signs requested a review from deltanedas December 1, 2024 19:13
@Stop-Signs
Copy link
Contributor Author

Stop-Signs commented Dec 1, 2024

OK so, after some recommendations from velcro and me figuring out how to make the tables work, it now works as intended.

the probability was messing with the chance for the RPG so ill let direction decide whether they get it or not.

@Stop-Signs Stop-Signs requested a review from MilonPL December 1, 2024 20:05
@Stop-Signs
Copy link
Contributor Author

Just to make it clear, I asked direction (lady) about the spare rocket and she said it was fine
image

@IamVelcroboy
Copy link
Member

@MilonPL @deltanedas if you are satisfied and can dismiss your change requests, this can be merged

@deltanedas
Copy link
Member

20% can be removed later

@deltanedas deltanedas merged commit 7f608b6 into DeltaV-Station:master Dec 1, 2024
16 checks passed
table: !type:GroupSelector
children:
- id: GunSafeBeamDevastator
- id: GunSafeRocketLauncher
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF newline

- id: WeaponLauncherRocket
- id: CartridgeRocket
prob: 0.2
- id: WeaponBeamDevastator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

id: LootSpawnerSecuritySuperweapon
name: security superweapon spawner
suffix: superweapon
parent: MarkerBase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parent after type

@MilonPL
Copy link
Member

MilonPL commented Dec 1, 2024

fuck!!

@deltanedas
Copy link
Member

can be changed later, at least it can get mapped now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants