Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports IPCs from Goob/EE #2800

Merged
merged 16 commits into from
Feb 3, 2025
Merged

Ports IPCs from Goob/EE #2800

merged 16 commits into from
Feb 3, 2025

Conversation

Spielern
Copy link
Contributor

@Spielern Spielern commented Jan 25, 2025

About the PR

Ports IPCs from Goob-Station/Goob-Station#1100 and a portion of Goob-Station/Goob-Station#1235 (dc16cad)
This is my first PR and the scale is quite big, so I'm sure there are a few issues. Please go easy on me!

Why / Balance

IPCs are a very unique species, offering a lot of mechanical benefits and RP opportunities with extreme mechanical restrictions/implications.
While many people will first assume that this will take away from the Cyborg experience, my time playing IPCs on other servers has made it clear to me that the gameplay experience is significantly different between the two. IPCs allow players to RP as a silicon without the forced gameplay restrictions from Cyborg laws, letting players focus more on RP without distractions.
As someone who also loves to play Cyborg, having a playable species derived from Cyborgs that allows for more RP opportunities and freedom as a player character is extremely exciting.

For a simplified (and not fully complete) list of benefits/info/cons:

  • IPCs have an internal battery and must constantly charge it or they will enter a "critical" state where they must be recharged externally.
  • IPCs do not need to breathe.
  • IPCs are not law-bound in any way, and are free to RP their character as they would like.
  • IPCs are immune to barotrauma and cold damage.
  • IPCs take 1.5x heat damage
  • IPCs do not take heat damage from fire/high-temps and will instead overheat, killing them and requiring them to be rebooted when they cool down.
  • IPCs double shock damage.
  • IPCs cannot metabolize reagents.
  • IPCs cannot be healed by topicals or chemicals and instead must heal through welding for Brute damage, cables for Burn damage, and glass for Eye damage.
  • IPCs are immune to poison and radiation damage.
  • EMPs will instantly kill any IPC caught in them, requiring them to be recharged externally.
  • IPCs can be emagged to swiftly remove their powercell and near-instantly kill them.
  • IPCs will violently explode and shock their surroundings if defibrillators are used on them in their "critical" state.
  • IPCs cannot become psionic, unless they are the Mystagogue or Psionic Mantis

This PR contains only the basic IPC code and overheating system, and does not include any of the bug fixes/QoL changes/additions that are already present on other servers, so as to keep things simple and easy to change in case Delta wishes to implement balance or additions differently.

Media

Emotes
https://github.com/user-attachments/assets/beb968fa-3201-46c7-be49-5f0d2951c1f5

Encryption Keys
https://github.com/user-attachments/assets/fc8ea4da-d322-4686-9df0-8832bcb22590

Radiation Immunity
https://github.com/user-attachments/assets/7f73a0ac-a602-4143-b13f-486f3ad1cbfd

Heat Vulnerability
https://github.com/user-attachments/assets/2c236897-cdfb-4282-8b88-fc42ad3f5e9d

Welding/Cable/Glass repairs & Rebooting
https://github.com/user-attachments/assets/789d3b04-c0e7-4851-8592-9696a56e7531

Charging
https://github.com/user-attachments/assets/216d67da-ba90-4385-a928-5b2ac9ea6769

EMPs
https://github.com/user-attachments/assets/195282ca-0eb6-4644-955e-8eed1005c13a

Emag
https://github.com/user-attachments/assets/bd94a599-be26-4f1a-8135-471c8653a63c

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • add: Added IPCs as a playable species.

@Spielern Spielern requested review from a team as code owners January 25, 2025 21:04
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Documentation Changes any xml or md files Changes: Sprite Changes any png or json in an rsi Changes: Audio Changes any audio files size/XL Over 1024 lines and removed S: Needs Review labels Jan 25, 2025
Copy link
Contributor

github-actions bot commented Jan 25, 2025

RSI Diff Bot; head commit 97a57c4 merging into e00d674
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_EE/Mobs/Customization/ipc_antenna.rsi

State Old New Status
ipc_antenna_antlers Added
ipc_antenna_crowned Added
ipc_antenna_cyberhead Added
ipc_antenna_droneeyes Added
ipc_antenna_light Added
ipc_antenna_lightb Added
ipc_antenna_sidelights Added
ipc_antenna_tesla Added
ipc_antenna_towers Added
ipc_antenna_tv Added

Resources/Textures/_EE/Mobs/Customization/ipc_screens.rsi

State Old New Status
ipc_screen_blank Added
ipc_screen_blue Added
ipc_screen_breakout Added
ipc_screen_bsod Added
ipc_screen_console Added
ipc_screen_ecgwave Added
ipc_screen_eight Added
ipc_screen_exclaim Added
ipc_screen_eyes Added
ipc_screen_eyesangry Added
ipc_screen_eyestall Added
ipc_screen_frown Added
ipc_screen_glider Added
ipc_screen_goggles Added
ipc_screen_heart Added
ipc_screen_l Added
ipc_screen_loading Added
ipc_screen_monoeye Added
ipc_screen_nature Added
ipc_screen_orange Added
ipc_screen_pink Added
ipc_screen_question Added
ipc_screen_rainbowdiag Added
ipc_screen_rainbowhoriz Added
ipc_screen_redtext Added
ipc_screen_rgb Added
ipc_screen_ring Added
ipc_screen_scroll Added
ipc_screen_shower Added
ipc_screen_sinewave Added
ipc_screen_smile Added
ipc_screen_squarewave Added
ipc_screen_stars Added
ipc_screen_static Added
ipc_screen_tetris Added
ipc_screen_textdrop Added
ipc_screen_tv Added
ipc_screen_windowsxp Added
ipc_screen_yellow Added

Edit: diff updated after 97a57c4

@deltanedas
Copy link
Member

IPCs take double heat damage and will overheat from high temperatures, killing them quickly.

replace this with Goob-Station/Goob-Station#1232, which is in this commit

getting 1000 burn damage because someone on fire ran into you is ass, especially if an artifact full firestack effect happens

@Spielern
Copy link
Contributor Author

replace this with Goob-Station/Goob-Station#1232, which is in this commit

getting 1000 burn damage because someone on fire ran into you is ass, especially if an artifact full firestack effect happens

Should I be grabbing just the code for fire/overheating, or other code/fixes from the commit? Not sure what would be preferred/wanted.

@deltanedas
Copy link
Member

the whole commit should be good

@Spielern
Copy link
Contributor Author

Including the mech code? Sorry for asking again, just want to make sure I'm not misinterpreting.

@deltanedas
Copy link
Member

yes

@Sifb26
Copy link
Contributor

Sifb26 commented Jan 26, 2025

Direction review will be finished by next week at the latest.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 29, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Spielern <iesteed2@gmail.com>
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 31, 2025
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! These look mostly great, we're requesting a few small tweaks.

@Lyndomen
Copy link
Contributor

Lyndomen commented Feb 2, 2025

Oh and I forgor, but we also would like the emag brain popping out bit disabled.

@Spielern
Copy link
Contributor Author

Spielern commented Feb 2, 2025

Oh and I forgor, but we also would like the emag brain popping out bit disabled.

Brain doesn't pop out- just removes the lock permanently from the body, meaning anyone can remove their cell or encryption keys. Is that what you want removed?

@Lyndomen
Copy link
Contributor

Lyndomen commented Feb 2, 2025

Oh and I forgor, but we also would like the emag brain popping out bit disabled.

Brain doesn't pop out- just removes the lock permanently from the body, meaning anyone can remove their cell or encryption keys. Is that what you want removed?

Okay, that's perfectly fine. Thank you!

@deltanedas deltanedas merged commit 822fa43 into DeltaV-Station:master Feb 3, 2025
16 checks passed
@Spielern Spielern deleted the port-ipc branch February 3, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/XL Over 1024 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants