-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports IPCs from Goob/EE #2800
Ports IPCs from Goob/EE #2800
Conversation
RSI Diff Bot; head commit 97a57c4 merging into e00d674 Resources/Textures/_EE/Mobs/Customization/ipc_antenna.rsi
Resources/Textures/_EE/Mobs/Customization/ipc_screens.rsi
|
replace this with Goob-Station/Goob-Station#1232, which is in this commit getting 1000 burn damage because someone on fire ran into you is ass, especially if an artifact full firestack effect happens |
Should I be grabbing just the code for fire/overheating, or other code/fixes from the commit? Not sure what would be preferred/wanted. |
the whole commit should be good |
Including the mech code? Sorry for asking again, just want to make sure I'm not misinterpreting. |
yes |
Direction review will be finished by next week at the latest. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Spielern <iesteed2@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! These look mostly great, we're requesting a few small tweaks.
Content.Server/_EE/Silicon/WeldingHealable/WeldingHealingComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/_EE/Silicon/BlindHealing/BlindHealingComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/_EE/Silicon/WeldingHealable/WeldingHealingComponent.cs
Outdated
Show resolved
Hide resolved
Oh and I forgor, but we also would like the emag brain popping out bit disabled. |
Brain doesn't pop out- just removes the lock permanently from the body, meaning anyone can remove their cell or encryption keys. Is that what you want removed? |
Okay, that's perfectly fine. Thank you! |
About the PR
Ports IPCs from Goob-Station/Goob-Station#1100 and a portion of Goob-Station/Goob-Station#1235 (dc16cad)
This is my first PR and the scale is quite big, so I'm sure there are a few issues. Please go easy on me!
Why / Balance
IPCs are a very unique species, offering a lot of mechanical benefits and RP opportunities with extreme mechanical restrictions/implications.
While many people will first assume that this will take away from the Cyborg experience, my time playing IPCs on other servers has made it clear to me that the gameplay experience is significantly different between the two. IPCs allow players to RP as a silicon without the forced gameplay restrictions from Cyborg laws, letting players focus more on RP without distractions.
As someone who also loves to play Cyborg, having a playable species derived from Cyborgs that allows for more RP opportunities and freedom as a player character is extremely exciting.
For a simplified (and not fully complete) list of benefits/info/cons:
This PR contains only the basic IPC code and overheating system, and does not include any of the bug fixes/QoL changes/additions that are already present on other servers, so as to keep things simple and easy to change in case Delta wishes to implement balance or additions differently.
Media
Emotes
https://github.com/user-attachments/assets/beb968fa-3201-46c7-be49-5f0d2951c1f5
Encryption Keys
https://github.com/user-attachments/assets/fc8ea4da-d322-4686-9df0-8832bcb22590
Radiation Immunity
https://github.com/user-attachments/assets/7f73a0ac-a602-4143-b13f-486f3ad1cbfd
Heat Vulnerability
https://github.com/user-attachments/assets/2c236897-cdfb-4282-8b88-fc42ad3f5e9d
Welding/Cable/Glass repairs & Rebooting
https://github.com/user-attachments/assets/789d3b04-c0e7-4851-8592-9696a56e7531
Charging
https://github.com/user-attachments/assets/216d67da-ba90-4385-a928-5b2ac9ea6769
EMPs
https://github.com/user-attachments/assets/195282ca-0eb6-4644-955e-8eed1005c13a
Emag
https://github.com/user-attachments/assets/bd94a599-be26-4f1a-8135-471c8653a63c
Requirements
Breaking changes
Changelog
🆑