Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logitechdrip - quick sprite update #2822

Merged
merged 24 commits into from
Jan 30, 2025

Conversation

kushbreth
Copy link
Contributor

About the PR

Gave cargo techs a pair of overalls, a pair of pants, and a romper. This replaces the original default cargo tech uniforms, and gives those to cargo assistants *some slight updates to sprites

Why / Balance

Visually distinguishes professional and experienced technicians from lowly plebian assistants

Technical details

yml changes to loadout code, new jumpsuit yml and sprites, and modified cargo assistant yml

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • add: Added new uniforms for cargo techs)

@kushbreth kushbreth requested review from a team as code owners January 30, 2025 21:18
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi and removed S: Needs Review labels Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

RSI Diff Bot; head commit f4468a9 merging into 91de609
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Clothing/Uniforms/Jumpskirt/cargotechromper.rsi

State Old New Status
equipped-INNERCLOTHING Modified

Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cargotechoveralls.rsi

State Old New Status
equipped-INNERCLOTHING Modified

Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cargotechpants.rsi

State Old New Status
equipped-INNERCLOTHING Modified

Edit: diff updated after f4468a9

@ThataKat
Copy link
Contributor

Could you add some media to show the changes? Unless it's super minor

If it is super minor then consider it direction approved since the base PR was already approved

@github-actions github-actions bot added size/XS Under 16 lines and removed size/M 64-255 lines S: Merge Conflict Fix your PR! labels Jan 30, 2025
@kushbreth
Copy link
Contributor Author

kushbreth commented Jan 30, 2025

Could you add some media to show the changes? Unless it's super minor

If it is super minor then consider it direction approved since the base PR was already approved

it's SUPER minor - there was a floating transparent sleeve completely off the model in the jumpskirt and i only changed a maximum of 4 pixels in the collar area for the rest. ultimately no changes were made aside from fixing these errors

@kushbreth
Copy link
Contributor Author

@ThataKat everything looks good, not sure if i need to ping delta for a merge or not - just trying to get it pushed since it's a pretty ugly visual error LOL. thank you!

@Radezolid Radezolid merged commit 8fcd3c3 into DeltaV-Station:master Jan 30, 2025
15 checks passed
@kushbreth kushbreth deleted the logitechdrip branch January 31, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/XS Under 16 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants