Add surgical cleanliness and sanitation

[sowelipililimute]

About the PR

• surgical tools and gloves can now get dirty and require sanitization
• soap can be used to sanitize surgical tools slowly

Why / Balance

• surgery is very low-committal and LRP-feeling as it is, requiring tools to be sanitized makes more of a commitment required to do surgery well and adds a mechanical basis for surgeons to care about sanitation
• this was balanced around the assumption that you'd probably want to change your gloves and tools after a part transplant, so all of the steps involved in a heart surgery add up to ~50 dirtiness, after which point poison damage will start to happen if all of that dirtiness went to a single pair of gloves and a tool
• surgical steps have a maximum cap on how much poison damage they can do at once, in order to prevent a 5000 dirtiness scalpel from instantly round removing someone after an incision
• cross-contamination between patients is a big no-no, and adds a ton of dirtiness to the calculations

Technical details

• components
  • SurgeryCleansDirtComponent: add it to items to allow them to sanitize tools and gloves manually
  • SurgeryCrossContaminationComponent: keeps track of other patients' DNA that has been on this tool
  • SurgeryContaminableComponent: add it to mobs that need to react to having (un)sanitary surgery equipment used on them
  • SurgeryDirtinessComponent: keeps track of how dirty a component is after surgery
  • SurgeryStepDirtinessComponent: add it to surgery steps to adjust how much dirtiness they cause after a step is done
• systems
  • SurgeryCleanSystem: new system that handles the examination of dirtied items and of scrubbing them with soap
  • SurgerySystem: augmented with sanitization checks after a step is completed in order to dirty involved tools and to deal damage if they're too dirty
• base mob now has SurgeryContaminableComponent
• base soap now has SurgeryCleansDirt
• surgery steps now have SurgeryStepDirtiness

Media

mothdirty.mp4

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an ingame showcase.

After This PR

This PR has follow-up opportunities, such as adding an autoclave or other methods for sanitizing tools and gloves faster than soaps do

Changelog

🆑

• add: Surgical gloves and equipment can now get dirty and require sanitzation

[Avalon-Proto]

Question - the advanced tools. As they are all energy based, should get dirty slower no? Or at the very least the searing tool and energy scalpel

[sowelipililimute]

Question - the advanced tools. As they are all energy based, should get dirty slower no? Or at the very least the searing tool and energy scalpel

that could make sense

[deltanedas]

.

[Lyndomen]

Direction review, 24 hours!

[Lyndomen]

Direction Approved! We really appreciate your work here, and how toxin damage is now less of a boolean factor in the equation.

[deltanedas]

1. move everything to shared, popups and doafter have shared systems
2. make doafter time scale with dirtness or be repeating and only remove a small amount of dirt per shorter doafter. same time to clean near-sterile and filthy tools is bad

[sowelipililimute]

move everything to shared, popups and doafter have shared systems

DNA is fully server-sided, and DNA needs to be tested for in order to see if there's something to be sanitized. most everything else is already in shared.

[deltanedas]

so have the dna specific part in server only

no reason for interaction and stuff to be in server

[sowelipililimute]

so what exactly happens if client doesn't think the verb can be done but the server does because the server sees extant DNA that the client can't?

[sowelipililimute]

make doafter time scale with dirtness or be repeating and only remove a small amount of dirt per shorter doafter. same time to clean near-sterile and filthy tools is bad

also i'm curious how you expect that to incorporate into the current model where it daisychains to the forensics scrubbing after completing the doafter

[deltanedas]

doafter repeating can still be used regardless of the forensics code in server its a field on do after args

[sowelipililimute]

i don't mean the normal forensics code that runs when you touch an item, i mean the fact that at the moment we want the sterilisation to daisychain to forensics because if you sterilise something medically you've probably nuked all the evidence too, and that's what it currently does

[deltanedas]

yes you can still call that in a virtual method that does the forensic event on server

[sowelipililimute]

not asking about moving it to shared, I'm asking about how I'm supposed to mix "a surgery doafter is partial and can take 10ticks vs forensics taking 100ticks in a single go"

[deltanedas]

just have it remove forensics on first doafter, you can use soap to remove it anyway so theres no "exploit"

[sowelipililimute]

relocated the logic into shared, it is now a repeating doafter

[deltanedas]

more comments still need changing to not be all on 1 line...

[sowelipililimute]

that's all of them now for realsies

[deltanedas]

i dont trust the popups, ill test it out later

[sowelipililimute]

popups are fixed