Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more folders to the Bureaucracy crate #2863

Conversation

sowelipililimute
Copy link
Contributor

About the PR

The bureaucracy crate now has more types of folders, and 2 of each type of folder

Why / Balance

3 folders is a disappointing amount of them to have, and the available colours are commonly already mapped for the paperwork roles that have them.
This increases both the variety of folders, and how many folders you can get.

Technical details

  • add more folders to the cargo crate fill

Media

grafik

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog

🆑

  • add: Bureaucracy crate has more and more varied folders

@sowelipililimute sowelipililimute requested a review from a team as a code owner February 2, 2025 23:11
@github-actions github-actions bot added S: Needs Review size/XS Under 16 lines Changes: YML Changes any yml files and removed size/XS Under 16 lines labels Feb 2, 2025
@Radezolid
Copy link
Contributor

The 5 spesos test fail.

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/bureaucracy-crate-folders branch from e05222d to a99f697 Compare February 2, 2025 23:47
@github-actions github-actions bot added the size/XS Under 16 lines label Feb 2, 2025
@Radezolid
Copy link
Contributor

The 5 spesos test fail.

I can't read.

Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solve the test fail, you need to make sure the items inside are lower than 30 in total, my recommendation is to cut down on those papers.

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/bureaucracy-crate-folders branch from a99f697 to bad7225 Compare February 3, 2025 00:27
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to wait on direction's input.

@Radezolid Radezolid requested a review from a team February 3, 2025 00:48
@Radezolid Radezolid merged commit ce5f1ce into DeltaV-Station:master Feb 3, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review size/XS Under 16 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants