More IPC Fixes #2886
Open
More IPC Fixes #2886
+11
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into more-ipc-fixes IPC emote fixes
github-actions
bot
added
S: Needs Review
size/S
Signed-off-by: Spielern <iesteed2@gmail.com>
Signed-off-by: Spielern <iesteed2@gmail.com>
Signed-off-by: Spielern <iesteed2@gmail.com>
Radezolid
requested changes
Feb 5, 2025
Resources/Prototypes/_DV/Roles/Jobs/Command/administrative_assistant.yml
Show resolved
Hide resolved
Cyborgs don't actually have the id "Silicon", adding it could potentially cause some issues |
deltanedas
requested changes
Feb 5, 2025
You're right, that's dumb though... you can do what Deltanedas says, but removing the requiresAll and axing the Vocal so non-silicon can't use them |
Signed-off-by: Spielern <iesteed2@gmail.com>
Signed-off-by: Spielern <iesteed2@gmail.com>
Signed-off-by: Spielern <iesteed2@gmail.com>
Signed-off-by: Spielern <iesteed2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes IPC Administrative Assistants not spawning with encryption keys
Adds Cyborg emotes to IPCs
Technical details
Removes the whitelist requirement for Cyborg emotes with a whitelist in the Cyborg and IPC .yml files
Will cause a duplicate headset to be created if a headset is also selected in the loadout. I was unsure if this should be removed or not, so I'm leaving it to a separate PR. Please let me know if I should include the loadout's deletion in here as well.
Requirements
Breaking changes
Changelog
🆑