Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traitor reputation real #2913

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Feb 7, 2025

About the PR

real...

based on this design doc but objectives can be freely picked instead of forced

instead of just taking item youll have to extract it with a syndicate fulton, a fulton with a cooldown of a minute that sends things to the syndie vault
adds ransom objectives for fultoning someone. they can just right click to remove it so you will have to keep them cuffed too. they get sent to the syndie jail until ransom gets paid :trollface:

ransoms for people start at 10k and can be modified like so:

  • 50% if they went crit
  • 20% if they died, objective failed too
  • 50% for passengers, theyre not nt employees who cares
  • 2x for sec, 2.5x for warden
  • 3x for most command, 2x for LO since its harder to pay the ransom without one probably
  • 4x for hos
  • 5x for cap
  • 10x if you somehow manage to both have centcom and steal them

todo:

  • buying back ransomed mobs
  • rework offerings more
  • guidebook

to be done later:

  • data knife objective
  • something to make nuke disk objective not cuck loneops
  • idk port more stuff from tg

Why / Balance

always stay evil

old system bad from a gameplay perspective:

  • get your greentext 10 minutes in and do nothing for the rest of the round
  • sec gets a cold case and the traitor does nothing anymore, so sec has nothing to do and goes cryo

high end gear like bloodred and china lake are gated behind high reputation so you have to do smaller tasks before going to war with sec, by which time they should have plenty of reasons to have arrested you already, leading to a more cat and mouse of constant antagonism rather than do the funny thing once and forget you were ever a traitor

Technical details

:trollface:

Media

current syndie prison
10:27:10

contract button real
11:18:53

uplink stuff

you can always buy ammo

11:29:43

surplus is unaffected stay gambling

11:30:52

some stuff with 0 rep

11:30:41

11:30:25

11:29:49

no automatic objectives anymore
09:43:28

current contracts ui :trollface:
11:32:03

paid for completing contract real
03:53:57

greentext...
10:45:38
10:46:13

level up real
11:58:39

ransomed...
12:39:31

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

anything added to uplink in the future will need reputation added

Changelog
🆑

  • add: Completely reworked traitors to use the new contracts system. Read the guidebook!
  • remove: Removed the nuke disk objective until it doesn't softlock nukies.

@deltanedas deltanedas requested a review from a team February 7, 2025 00:08
@github-actions github-actions bot added size/XL Over 1024 lines S: Needs Review Changes: YML Changes any yml files Changes: UI Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Feb 7, 2025
@Lyndomen
Copy link
Contributor

Lyndomen commented Feb 7, 2025

Is this draft running yet? Gonna test whenever it is

@deltanedas
Copy link
Member Author

client doesnt compile and it fails to pick objectives

@Spielern
Copy link
Contributor

Spielern commented Feb 7, 2025

holy shit??? this is actually incredible

@AftrLite
Copy link
Contributor

AftrLite commented Feb 7, 2025

Fascinating

@kipdotnet
Copy link

Oh this is really cool. Putting a bookmark on this

@github-actions github-actions bot added size/L 256-1023 lines and removed size/XL Over 1024 lines labels Feb 9, 2025
@github-actions github-actions bot added the Changes: Documentation Changes any xml or md files label Feb 10, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Feb 10, 2025
@deltanedas
Copy link
Member Author

@Lyndomen stuff mostly works now you can try it out locally (extraction objectives require sudo cvar shuttle.emergency true then restarting the round)

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Feb 10, 2025
@Lyndomen
Copy link
Contributor

@Lyndomen stuff mostly works now you can try it out locally (extraction objectives require sudo cvar shuttle.emergency true then restarting the round)

Thanks pro, will get feedback by this time tmrw

@Lyndomen
Copy link
Contributor

image

syndie jail looks really nice, good mapping. Taser needs a recharger. jail could use windoors to pass the gremlins food, actually looking at it rn u probably didnt intend to have this map be reviewed yet so im gonna not nitpick 😎

uplink implant auto assigned me a traitor objective when i spawned in with it

@deltanedas
Copy link
Member Author

uplink implant doesnt support contracts (yet) so you would have an uplink with no objectives which is bad

theres still work to do for the prison like adding the marshal ghost role :trollface:
and removing headsets so funny prisoners dont ask john centcom for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Map Changes: UI Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants