Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From structured curvilinear #319

Merged
merged 11 commits into from
Feb 13, 2025
Merged

From structured curvilinear #319

merged 11 commits into from
Feb 13, 2025

Conversation

Huite
Copy link
Collaborator

@Huite Huite commented Feb 7, 2025

Fixes #316

@Huite Huite requested a review from veenstrajelmer February 7, 2025 19:34
Copy link
Collaborator

@veenstrajelmer veenstrajelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are in the linked issue: #316.

Huite added 3 commits February 12, 2025 20:28
This is easier, since internal of the function, we know which faces are triangles and can set the fill value of -1 there.
@Huite Huite merged commit db643c1 into main Feb 13, 2025
14 checks passed
@Huite Huite deleted the from-structured-curvilinear branch February 13, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_structured does not support non-monotonic indexes
2 participants