Pink petal count #2632
Open
Pink petal count #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin/src/main/java/com/denizenscript/denizen/utilities/MultiVersionHelper1_19.java
Outdated
Show resolved
Hide resolved
mcmonkey4eva
previously approved these changes
Jun 25, 2024
|
See message on Discord - not really able to test rn, but afaics it should work fine? having version helper methods isn't awful, but would be nicer to just do it normally if possible |
mcmonkey4eva
previously approved these changes
Jan 23, 2025
tal5
requested changes
Jan 29, 2025
| @@ -132,6 +131,9 @@ else if (isRespawnAnchor()) { | |||
| else if (isCandle()) { | |||
| return getCandle().getCandles(); | |||
| } | |||
| else if ((NMSHandler.getVersion().isAtLeast(NMSVersion.v1_19) && material.getModernData() instanceof PinkPetals pinkPetals)) { | |||
There was a problem hiding this comment.
Pretty sure these are redundant double brackets on all of these?
mcmonkey4eva
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added count property to pink petals