Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 add additional methods #4

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

m4sterbunny
Copy link
Contributor

Adds build instructions and attempts to ignore build-related files

Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ethereum-json-rpc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 3:33pm

@Destiner
Copy link
Owner

Destiner commented Dec 1, 2024

Thanks! Could you pls remove package.json and bun.lockb from the .gitignore? They are essential to make sure you install the proper version of each package.

@m4sterbunny
Copy link
Contributor Author

I can -- normally each user does an install locally to update their package.json, but if you feel it's safe to push my version to main, tis fine my me.

@m4sterbunny
Copy link
Contributor Author

Hmm actually not sure what you are asking for:
my status is

  • bun.lockb
  • package.json
    have diffs
    You don't want either of these files committed AND you don't want gitignore updated to prevent these files being included in diff?

@Destiner Destiner merged commit acefa58 into Destiner:main Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants