Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleHandler to make minimal Attributes functional #105

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

GDYendell
Copy link
Contributor

This allows creating Attributes without a Handler for parameters that are only used for internal controller logic and not sent directly to a device.

Fixes #101

This allows creating Attributes without a Handler for parameters that
are only used for internal controller logic and not sent directly to a
device.
@GDYendell GDYendell requested a review from d-perl December 10, 2024 12:19
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (2153173) to head (d789693).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs/attributes.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   87.75%   87.76%           
=======================================
  Files          28       28           
  Lines        1184     1193    +9     
=======================================
+ Hits         1039     1047    +8     
- Misses        145      146    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, exactly what I needed, thank you!

@d-perl d-perl merged commit 0ab3841 into main Dec 10, 2024
18 checks passed
@d-perl d-perl deleted the simple-handler branch December 10, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute._value is not updated with the PV
2 participants