-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
76 pass backend options on init and provide pv name formatting options #77
Conversation
380c9e5
to
0991fab
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 82.56% 85.78% +3.22%
==========================================
Files 23 23
Lines 935 957 +22
==========================================
+ Hits 772 821 +49
+ Misses 163 136 -27 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There is a lot more in this that the name suggests. Most of the changes are related to adding the naming convention config, could that be taken out? Is it tightly coupled somehow? |
Passing the options on init is required by the naming convention config implementation. |
Also added options for formatting the pv names.
Also made it so that scan tasks are explicitly torn down when the backend is deleted.
82b7055
to
c1d80c8
Compare
I accidentally included
here. I dropped it from the branch but it's not been removed from this PR for whatever reason. |
Closes #76