Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

76 pass backend options on init and provide pv name formatting options #77

Closed
wants to merge 10 commits into from

Conversation

evalott100
Copy link
Contributor

@evalott100 evalott100 commented Nov 18, 2024

Closes #76

@evalott100 evalott100 force-pushed the 76-pass-backend-options-on-init-instead-of-run branch from 380c9e5 to 0991fab Compare November 19, 2024 08:21
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (76cf387) to head (722cc37).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs/backends/epics/backend.py 70.00% 3 Missing ⚠️
src/fastcs/backend.py 50.00% 1 Missing ⚠️
src/fastcs/backends/epics/ioc.py 98.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   82.56%   85.78%   +3.22%     
==========================================
  Files          23       23              
  Lines         935      957      +22     
==========================================
+ Hits          772      821      +49     
+ Misses        163      136      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@GDYendell
Copy link
Contributor

There is a lot more in this that the name suggests. Most of the changes are related to adding the naming convention config, could that be taken out? Is it tightly coupled somehow?

@evalott100 evalott100 changed the title 76 pass backend options on init instead of run 76 pass backend options on init and provide pv name formatting options Nov 19, 2024
@evalott100
Copy link
Contributor Author

Most of the changes are related to adding the naming convention config, could that be taken out? Is it tightly coupled somehow?

Passing the options on init is required by the naming convention config implementation.

@evalott100 evalott100 force-pushed the 76-pass-backend-options-on-init-instead-of-run branch from 82b7055 to c1d80c8 Compare November 19, 2024 15:48
@evalott100
Copy link
Contributor Author

evalott100 commented Nov 20, 2024

I accidentally included

made update_period optional on Updater 722cc37

here. I dropped it from the branch but it's not been removed from this PR for whatever reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass backend options on init instead of run
2 participants