Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional version command to launcher #96

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

marcelldls
Copy link
Contributor

version is a useful cli command - this option adds the command if the developer passes a version that should be output when executing ${my_fastcs_device} version

@marcelldls marcelldls requested a review from GDYendell December 3, 2024 13:59
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (7d602ce) to head (dc6f1a0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   87.52%   87.58%   +0.06%     
==========================================
  Files          28       28              
  Lines        1162     1168       +6     
==========================================
+ Hits         1017     1023       +6     
  Misses        145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GDYendell
Copy link
Contributor

Would it be possible to print the FastCS version as well as the controller version?

@marcelldls
Copy link
Contributor Author

Thats a good idea

@marcelldls
Copy link
Contributor Author

The default is that it will print FastCS version. If a version of the implemented controller is passed, it will also be shown

(.venv) [esq51579@pc0146 FastCS]$ thorlabs-mff-fastcs version
INFO: PVXS QSRV2 is loaded, permitted, and ENABLED.
ThorlabsMFF: my_version
FastCS: 0.7.1.dev19+gdc6f1a0

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Note if we move towards having a single FastCS application entry point then it will need to import the controller and could potentially get the controller version itself.

@GDYendell GDYendell merged commit 35b1870 into main Dec 3, 2024
15 checks passed
@GDYendell GDYendell deleted the pass-cli-version branch December 3, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants