Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1622: Add units and decimal places to visit summary page #911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LIMS-1622: Add units and decimal places to visit summary page #911

wants to merge 1 commit into from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1622

Summary:

Several fields on the summary page are missing units. Also, Rmeas Inner could do with 3 decimal places, but completeness only needs 1 decimal place.

Changes:

  • Add units to unit cell, resolution, completeness and anomalous completeness
  • Edit number of decimal places

To test:

  • Go to a visit, then click on Summary to go to eg /dc/summary/visit/mx23694-130
  • Check unit cell, resolution, completeness and anomalous completeness have appropriate units
  • Check Rmeas Inner has 3 decimal places, but all the completeness values have only 1 decimal place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees
No one assigned
Labels
Ready to Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @gfrn