Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block until environment reloaded #743

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Block until environment reloaded #743

merged 7 commits into from
Jan 21, 2025

Conversation

callumforrester
Copy link
Contributor

Fixes #742

@callumforrester callumforrester mentioned this pull request Dec 2, 2024
Closed
@callumforrester callumforrester mentioned this pull request Dec 18, 2024
Closed
@ZohebShaikh ZohebShaikh force-pushed the 742-environment-reload branch from 2005a4f to d8a9a14 Compare January 17, 2025 14:45
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (5d8524e) to head (3100386).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   93.41%   93.43%   +0.02%     
==========================================
  Files          38       38              
  Lines        2095     2102       +7     
==========================================
+ Hits         1957     1964       +7     
  Misses        138      138

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZohebShaikh ZohebShaikh marked this pull request as ready for review January 20, 2025 10:31
DiamondJoseph
DiamondJoseph approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if Callum's happy with it, here's a non-submitter approval

@ZohebShaikh ZohebShaikh merged commit b39aa8a into main Jan 21, 2025
31 checks passed
@ZohebShaikh ZohebShaikh deleted the 742-environment-reload branch January 21, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZohebShaikh ZohebShaikh ZohebShaikh left review comments

@DiamondJoseph DiamondJoseph DiamondJoseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment reload does not block
3 participants
@callumforrester @ZohebShaikh @DiamondJoseph