-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an external directory for container python cache #817
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 38 38
Lines 2111 2111
=======================================
Hits 1973 1973
Misses 138 138 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@tpoliaw did you find anything that worked for |
Yes, installing blueapi manually in the virtualenv with pip sorted it. It's just that Either way, I think it is unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
With this set, the pyc files are created in a mirror directory instead of the source tree. When running in a shared directory (as is the case for the scratch area used by bluapi), this prevents files being created with permissions that prevent other users removing them. See python docs at https://docs.python.org/3/using/cmdline.html#envvar-PYTHONPYCACHEPREFIX
b431b92
to
b6f60a8
Compare
With this set, the pyc files are created in a mirror directory instead
of the source tree. When running in a shared directory (as is the case
for the scratch area used by bluapi), this prevents files being created
with permissions that prevent other users removing them.
See python docs at
https://docs.python.org/3/using/cmdline.html#envvar-PYTHONPYCACHEPREFIX
Fixes #812
Instructions to reviewer on how to test:
__pycache__
directories created in the scratch areaChecks for reviewer