Update deployment docs based on deploying #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 93.46% 93.41% -0.05%
==========================================
Files 38 38
Lines 2112 2112
==========================================
- Hits 1974 1973 -1
- Misses 138 139 +1 ☔ View full report in Codecov by Sentry. |
callumforrester
approved these changes
Mar 3, 2025
docs/how-to/edit-live.md
Outdated
| ``` | ||
|
|
||
| :::{note} | ||
| If you do this then the value of `scratch.root` in your blueapi configuration is no longer particularly important, it only specifies where to mount the scratch area _inside_ the container. | ||
| ::: | ||
|
|
||
| The scratch folder that you're pointing to must exist, not already have a dodal deployment and have correct permissions e.g. |
There was a problem hiding this comment.
Could: It must not already have a deployment of the repo you want in general.
|
Tests are failing due to #843 so I'm merging this regardless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.