Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP numtracker integration #1059

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

callumforrester
Copy link
Contributor

Pairs with DiamondLightSource/blueapi#828

Fixes #ISSUE

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.63%. Comparing base (611af93) to head (9b431c2).

Files with missing lines Patch % Lines
src/dodal/common/beamlines/beamline_utils.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   97.68%   97.63%   -0.06%     
==========================================
  Files         160      160              
  Lines        6615     6626      +11     
==========================================
+ Hits         6462     6469       +7     
- Misses        153      157       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant