Trigger Zocalo and turn on feedback after all collections in MSP #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
=======================================
Coverage 87.33% 87.33%
=======================================
Files 104 104
Lines 6995 6997 +2
=======================================
+ Hits 6109 6111 +2
Misses 886 886
|
olliesilvester
requested changes
Mar 4, 2025
| def start_dict(plan_name: str = "test_plan_name", env: str = "test_env"): | ||
| return {CONST.TRIGGER.ZOCALO: plan_name, "zocalo_environment": env} | ||
|
|
||
|
|
||
| class TestZocaloHandler: | ||
| def _setup_handler(self): | ||
| zocalo_handler = ZocaloCallback("test_plan_name", "test_env") | ||
| return zocalo_handler | ||
|
|
||
| def test_handler_doesnt_trigger_on_wrong_plan(self): |
There was a problem hiding this comment.
I think we need an assert here now
There was a problem hiding this comment.
Or we can probably remove this test entirely in favour of test_zocalo_start_and_end_not_triggered_if_ispyb_ids_not_present
| "mx_bluesky.common.external_interaction.callbacks.common.zocalo_callback.ZocaloTrigger", | ||
| autospec=True, | ||
| ) | ||
| def test_handler_raises_on_the_end_of_a_plan_with_no_depositions( |
There was a problem hiding this comment.
Could: Add some tests which assert this exception if the document's scan_points or ispyb_dcids aren't in a correct form
Co-authored-by: olliesilvester <122091460+olliesilvester@users.noreply.github.com>
Co-authored-by: olliesilvester <122091460+olliesilvester@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #826 and fixes #848
Note, this is probably a breaking change for single rotation scans but given #847 I think that's ok.
Instructions to reviewer on how to test:
Checks for reviewer