-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sum dataset #2
Sum dataset #2
Conversation
I am not sure about the reformatting. I think it best to just stick with the current formatting unless we implement some tooling for format checking in CI and ideally auto formatting, because otherwise it will have to manually reviewed every time. |
Do you think we could add something like a settings file on .vscode that's standard for all detectors and use it from now on? I'm guilty on always setting the autoformat to false, but will stop from now on. |
I think just putting it in .vscode is not going to be sufficient. If it isn't strictly checked by a CI step then someone has to review the formatting and it massively increases the work required to review and distracts from the actual code changes. If we can do that and standardise it across all the repos (including odin-data) then that would be great, but until then I think just try to keep it consistent with the current formatting. Will it be difficult to pull out the formatting changes from this PR? |
Hi Gary, |
b482ae9
to
9cf36c1
Compare
OK that looks better without the formatting of the existing code, but could you also match the formatting of the existing code with the new code, e.g. indentation does not match. |
Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
Added the sum of all N channels connected to the detector as a dataset.