Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum dataset #2

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Sum dataset #2

merged 4 commits into from
Dec 3, 2024

Conversation

LuisFSegalla
Copy link
Collaborator

@LuisFSegalla LuisFSegalla commented Sep 5, 2024

Added the sum of all N channels connected to the detector as a dataset.

@LuisFSegalla LuisFSegalla self-assigned this Sep 5, 2024
@GDYendell
Copy link
Contributor

I am not sure about the reformatting. I think it best to just stick with the current formatting unless we implement some tooling for format checking in CI and ideally auto formatting, because otherwise it will have to manually reviewed every time.

@LuisFSegalla
Copy link
Collaborator Author

Do you think we could add something like a settings file on .vscode that's standard for all detectors and use it from now on? I'm guilty on always setting the autoformat to false, but will stop from now on.

@GDYendell
Copy link
Contributor

I think just putting it in .vscode is not going to be sufficient. If it isn't strictly checked by a CI step then someone has to review the formatting and it massively increases the work required to review and distracts from the actual code changes. If we can do that and standardise it across all the repos (including odin-data) then that would be great, but until then I think just try to keep it consistent with the current formatting.

Will it be difficult to pull out the formatting changes from this PR?

@LuisFSegalla
Copy link
Collaborator Author

Hi Gary,
It should be fine to remove the formatting, I deleted that commit from a local branch and it seemed to be okay without it. will do some extra checks to make sure it didn't affect anything else and will push the changes.

@LuisFSegalla LuisFSegalla force-pushed the sum branch 2 times, most recently from b482ae9 to 9cf36c1 Compare September 17, 2024 17:10
@GDYendell
Copy link
Contributor

OK that looks better without the formatting of the existing code, but could you also match the formatting of the existing code with the new code, e.g. indentation does not match.

Base automatically changed from pause-dev to main November 28, 2024 14:42
Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
@GDYendell GDYendell merged commit 435d44c into main Dec 3, 2024
3 checks passed
@GDYendell GDYendell deleted the sum branch December 3, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants