Fix FPS Limit and VSync Targeting Issues #101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
fpsTarget
and directly setting it as theApplication.targetFrameRate
. SincefpsTarget
is actually the value of the frame rate limit dropdown, it would result in the game setting the target frame rate to an unplayable value, like 3 or 6 (should be 30 or 60).fpsTarget
andvSyncRate
overwriting each other in their setter functions, resulting in seemingly no saving of those values, and them resetting on each restart/scene change.Setting both the framerate and vsync targets to 0 is now also allowed, resulting in an unlocked framerate
Note
Please check if everything works properly (mainly on Windows and MacOS) before merging