Fix deployment process to support non-root users #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to Dokploy#1126 Add error handling for deployment failures with non-root users. * **apps/api/src/utils.ts** - Throw an error with a message when deployment fails. * **apps/dokploy/server/utils/deploy.ts** - Throw an error with a message when deployment fails. * **apps/dokploy/server/api/routers/server.ts** - Add a check for sudo password prompts in the `serverSetup` function and throw an error if detected. - Emit an error in the observable if a sudo password prompt is detected during server setup.
|
This is throwing errors like this and not in the logs, can you add a video testing this?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1126
Add error handling for deployment failures with non-root users.
apps/api/src/utils.ts
apps/dokploy/server/utils/deploy.ts
apps/dokploy/server/api/routers/server.ts
serverSetupfunction and throw an error if detected.