-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize record timestamp as msgpack Timestamp #6
Conversation
It seems fluentd is hardcoded to treat it as integer, need to investigate if it can be changed |
Yes, it didn't work here with an error (this specific instance is after I messed with the format but same issue, seems to expect a number):
I was trying to see if fitting it to the format described in forward protocol specification would help, my understanding is that this is not the format fluent expects to ingest time but is for plugin writers, but was the best info I could find for accepted time formats, but I couldn't get it to work |
That's good one, we can try to encode it this way and see if it works UPD: couldn't make it work for now too |
@JoseCVM I figured out how to serialize timestamp as per spec |
56f05f1
to
db8dd49
Compare
Looking at source code, we can actually send float it seems This might be better due to having higher size |
Float parser is disgusting in fluentd This reverts commit ca8c12a.
19d914d
to
833ebea
Compare
@JoseCVM I released 0.4.1 with optional feature |
This changes serialization to msgpack extension type for Timestamp encoding
This should guarantee interpretation to be correct
Closes #5