Skip to content

Commit

Permalink
Added patch for view3d attributes and circel3d bug
Browse files Browse the repository at this point in the history
  • Loading branch information
DylanHojnoski committed Aug 15, 2024
1 parent 56a1005 commit 8a7ee59
Showing 1 changed file with 42 additions and 0 deletions.
42 changes: 42 additions & 0 deletions patches/jsxgraph+1.9.2.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
diff --git a/node_modules/jsxgraph/src/3d/circle3d.js b/node_modules/jsxgraph/src/3d/circle3d.js
index 2e9438a..2d4d980 100644
--- a/node_modules/jsxgraph/src/3d/circle3d.js
+++ b/node_modules/jsxgraph/src/3d/circle3d.js
@@ -264,7 +264,7 @@ JXG.createCircle3D = function (board, parents, attributes) {
el = new JXG.Circle3D(view, center, normal, radius, attr);

// update scene tree
- el.center.addChild(el);
+ el.center.addParents(el);
el.addChild(el.curve);

el.update();
diff --git a/node_modules/jsxgraph/src/3d/view3d.js b/node_modules/jsxgraph/src/3d/view3d.js
index b911e87..a23fa2f 100644
--- a/node_modules/jsxgraph/src/3d/view3d.js
+++ b/node_modules/jsxgraph/src/3d/view3d.js
@@ -1832,20 +1832,20 @@ JXG.createView3D = function (board, parents, attributes) {

attr = Type.copyAttributes(attributes, board.options, 'view3d');
view = new JXG.View3D(board, parents, attr);
- view.defaultAxes = view.create('axes3d', parents, attributes);
+ view.defaultAxes = view.create('axes3d', parents, attr);

x = coords[0];
y = coords[1];
w = size[0];
h = size[1];

- attr_az = Type.copyAttributes(attributes, board.options, 'view3d', 'az', 'slider');
+ attr_az = Type.copyAttributes(attr, board.options, 'view3d', 'az', 'slider');
attr_az.name = 'az';

- attr_el = Type.copyAttributes(attributes, board.options, 'view3d', 'el', 'slider');
+ attr_el = Type.copyAttributes(attr, board.options, 'view3d', 'el', 'slider');
attr_el.name = 'el';

- attr_bank = Type.copyAttributes(attributes, board.options, 'view3d', 'bank', 'slider');
+ attr_bank = Type.copyAttributes(attr, board.options, 'view3d', 'bank', 'slider');
attr_bank.name = 'bank';

/**

0 comments on commit 8a7ee59

Please sign in to comment.