Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain dask !=2024.12.0,!=2024.12.1 for performance #926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jan 28, 2025

Description

To do

  • Update dask constraint to dask !=2024.12.0,!=2024.12.1 in dev.yml, ci.yml and pyproject.toml
  • Validate dask=2025.1.0 update fixes performance issue using MVCE from here
  • Perform EAMxx v3 run for ua variable with dask=2025.1.0 -- pending perlmutter back online (2/3/25)
    • auxiliary_tools/cdat_regression_testing/892-bottleneck/run_script.py

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Jan 28, 2025
@tomvothecoder tomvothecoder added the DevOps CI/CD, configuration, etc. label Jan 28, 2025
@tomvothecoder tomvothecoder changed the title Constrain dask to avoid 2024.12.0 and 2024.12.1 Constrain dask !=2024.12.0,!=2024.12.1 for performance Jan 29, 2025
@tomvothecoder tomvothecoder marked this pull request as ready for review January 29, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps CI/CD, configuration, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Test dask=2025.1.0 resolves performance issue with large v3 datasets and update constraint (if yes)
1 participant