Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing paths and commands #664

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Jan 29, 2025

Summary

Objectives:

  • Make sure all environment_commands variants get set to use Unified when doing unified testing
  • Allow distinct parent directories for v2 and v3 testing data.

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
    • The primary changes are in tests/integration/utils.py. Everything else is a minor update to accommodate these changes or is auto-generated.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 merged commit bc5ba4f into main Jan 29, 2025
4 checks passed
@forsyth2 forsyth2 deleted the update-test-paths-commands branch January 29, 2025 20:06
@@ -280,7 +283,13 @@ def generate_cfgs(unified_testing=False, dry_run=False):
)
expansions = get_expansions()
if unified_testing:
expansions["diags_environment_commands"] = expansions[
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to wrap this in a if expansions["diags_environment_commands"] == "":, so it doesn't overwrite an explicitly set diags_environment_commands. Currently testing with Unified only, so fine for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed at #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant