Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove climo_land_subsection #679

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Remove climo_land_subsection #679

merged 1 commit into from
Feb 7, 2025

Conversation

forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Feb 7, 2025

Summary

Objectives:

  • Remove climo_land_subsection, opting to use the existing climo_subsection instead.

Issue resolution:

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Feb 7, 2025
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Feb 7, 2025

@chengzhuzhang I think I can just merge this. Per the discussion at #669 (comment).

@forsyth2 forsyth2 merged commit 5d268f1 into main Feb 7, 2025
5 checks passed
@forsyth2 forsyth2 deleted the issue-669-no-climo-land branch February 7, 2025 23:14
@chengzhuzhang
Copy link
Collaborator

@forsyth2 please follow through code review before merging. I have some questions for this one.

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Feb 7, 2025

@chengzhuzhang Sorry for the hasty merge. I did not think it required further code review; we had thoroughly discussed the design decision and the removal was simple.

Please let me know if I should revert the commit. What are your questions?

# Note: often `lat_lon_land` will require a different climo_subsection
# than the other sets (e.g., a climo subsection that includes land).
# That means this set will often need to be run as a separate subtask.
"lat_lon_land",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I was unsure about this line, and comment. But reading more of the code, I understand how dependencies handles differently for land vs atm, via "climate_section".

Copy link
Collaborator

@chengzhuzhang chengzhuzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My configuration file is working now. I can confirm #669 is resolved.

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Feb 8, 2025

Great, thank you @chengzhuzhang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Another parameter checking error: zppy.utils.ParameterNotProvidedError: climo_land_subsection
2 participants