[REFACTORING] 리뷰 수정/삭제, 신고하기 MVVM 변경 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 94-refactoring-mvvm-+-design-system-2 # Conflicts: # app/src/main/java/com/eatssu/android/ui/review/etc/ReportActivity.kt
3 tasks
Amepistheo
changed the title
HI-JIN2
approved these changes
Nov 23, 2023
Comment on lines
+25
to
+44
| val service = RetrofitImpl.retrofit.create(ReviewService::class.java) | ||
|
|
||
| viewModelScope.launch(Dispatchers.IO) { | ||
| service.delReview(reviewId).enqueue(object : Callback<Void> { | ||
| override fun onResponse(call: Call<Void>, response: Response<Void>) { | ||
| if (response.isSuccessful) { | ||
| if (response.code() == 200) { | ||
| handleSuccessResponse("삭제가 완료되었습니다.") | ||
| } else { | ||
| handleErrorResponse("삭제가 실패하였습니다.") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| override fun onFailure(call: Call<Void>, t: Throwable) { | ||
| handleErrorResponse("삭제가 실패하였습니다.") | ||
| } | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
저도 이렇게 수정해서 pr 반영했습니다! 제가 썼던 코드가 레포지토리 패턴이 아닌데 이름만 레포지토리인 원효대사 해골물 같은 코드였어서 그냥 뷰모델에서 서비스 호출하는걸로 바꿨어요!
다만 enqueue 방식이 아니라, runCatching를 쓰면 좀 더 가독성이 좋아질 것 같은데, 이건 다른 issue에서 처리하도록 합죠!
kotlin.runCatching {
setUserInfoService.setAge(
request = RequestSetAgeDto(
age = selectedAge.value ?: throw NullPointerException()
)
)
}.fold(onSuccess = {
_setAgeSuccessResponse.value = true
}, onFailure = { error ->
_setAgeErrorResponse.value = error.getErrorMessage()
})
}```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
개요
작업 사항
Check List
ctrl + alert + O⇒ 안쓰는 import 제거 /ctrl + alert + L⇒ 코드 정렬 등)main브랜치의 최신 상태를 반영하고 있는지 확인스크린샷 및 작동 영상