Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the TMPDIR is used as STORAGE if it is set #911

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

casparvl
Copy link
Collaborator

@casparvl casparvl commented Feb 12, 2025

This is one of three pieces split off from #903

Together with EESSI/eessi-bot-software-layer#299 this makes sure that TMPDIR is set to local_tmp as configured in app.cfg, and then with this PR we ensure that that TMPDIR is actually used everywhere if it is set. We also bind-mount it in the container, so that if any subsequent script calls a mktemp in the container, that is able to just created a dir within the mounted TMPDIR.

Copy link

eessi-bot bot commented Feb 12, 2025

Instance eessi-bot-mc-aws is configured to build for:

  • architectures: x86_64/generic, x86_64/intel/haswell, x86_64/intel/sapphire_rapids, x86_64/intel/skylake_avx512, x86_64/amd/zen2, x86_64/amd/zen3, aarch64/generic, aarch64/neoverse_n1, aarch64/neoverse_v1
  • repositories: eessi.io-2023.06-software, eessi.io-2023.06-compat

Copy link

eessi-bot bot commented Feb 12, 2025

Instance eessi-bot-mc-azure is configured to build for:

  • architectures: x86_64/amd/zen4
  • repositories: eessi.io-2023.06-software, eessi.io-2023.06-compat

@eessi-bot-casparvl
Copy link

Instance eessi-bot-casparvl is configured to build for:

  • architectures: x86_64/amd/zen4, x86_64/amd/zen2
  • repositories: eessi-hpc.org-2023.06-software, eessi.io-2023.06-software, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-compat

@gpu-bot-ugent
Copy link

gpu-bot-ugent bot commented Feb 12, 2025

Instance eessi-bot-vsc-ugent is configured to build for:

  • architectures: x86_64/amd/zen3
  • repositories: eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software, eessi-hpc.org-2023.06-software, eessi.io-2023.06-compat

@riscv-eessi-io-bot
Copy link

Instance eessi-bot-riscv is configured to build for:

  • architectures: riscv64/generic
  • repositories: riscv.eessi.io-20240402

@eessi-bot-trz42
Copy link

Instance trz42-GH200-jr is configured to build for:

  • architectures: aarch64/nvidia/grace
  • repositories: eessi.io-2023.06-software

Copy link
Collaborator

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should limit this (bind-mounting $TMPDIR) to cases where it is needed.

The setting of $STORAGE in bot/build.sh is ok, the bind-mount part should be moved to eessi_container.sh

bot/build.sh Outdated Show resolved Hide resolved
bot/build.sh Outdated Show resolved Hide resolved
…e TMP_IN_CONTAINER doesn't already contain that prefix
@casparvl
Copy link
Collaborator Author

Ok, so that worked #912 (comment) , I'm happy with this. I checked using

cat /path/to/slurm-9903139.out | grep \/tmp\/ | grep -v YUVixSjLBO

that there weren't any /tmp dirs that were not the tempdir created for the job in the bot-build.slurm, there weren't. I.e. all where /tmp/casparl/EESSI/eessi_job.YUVixSjLBO/<foo>

Copy link
Collaborator

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trz42 trz42 merged commit 69853c2 into EESSI:2023.06-software.eessi.io Feb 13, 2025
50 checks passed
Copy link

eessi-bot bot commented Feb 13, 2025

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2025.02.13

@riscv-eessi-io-bot
Copy link

PR merged! Moved [] to /home/eessibot/shared/trash_bin/EESSI/software-layer/2025.02.13

Copy link

eessi-bot bot commented Feb 13, 2025

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2025.02.13

@gpu-bot-ugent
Copy link

gpu-bot-ugent bot commented Feb 13, 2025

PR merged! Moved [] to /scratch/gent/vo/002/gvo00211/SHARED/trash_bin/EESSI/software-layer/2025.02.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants