Changes after rename of CCPPStandardNames --> ESMStandardNames #98
Conversation
mkavulich
commented
Mar 4, 2025
mkavulich
commented
- Remove references to CCPP except where relevant
- Cherry-pick changes to tools/write_standard_name_table.py from release branch that allows for subsections in standard names and markdown table
- Group CCPP-specific variables into a dedicated section
- Change some long_name descriptions to remove CCPP-specific wording
- A few more details in README.md
- Remove references to CCPP except where relevant - Cherry-pick changes to tools/write_standard_name_table.py from release branch that allows for subsections in standard names and markdown table - Group CCPP-specific variables into a dedicated section - Change some long_name descriptions to remove CCPP-specific wording - A few more details in README.md
mkavulich
requested review from
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mattldawson,
mwaxmonsky,
nusbaume,
peverwhee,
svahl991,
MayeulDestouches and
ss421
as code owners
| # end while | ||
| # end if | ||
| for std_name in section: | ||
| for std_name in sec: |
There was a problem hiding this comment.
Is there a reason these comments must be removed? We have been using them for years and they are very helpful for those of us with vision issues.
There was a problem hiding this comment.
I have a few arguments against including these comments. They require a non-trival amount of effort to ensure they are always correct, and it is not lintable so this will always be a manual effort. And if they are not kept up-to-date it does more harm than good. I am sympathetic to the needs of individual coding workflows, but can these kinds of decorations not be handled with IDE settings? I know Pycharm is extremely configurable, for example, and there are a number of suggestions online for people in similar situations.
There was a problem hiding this comment.
Can this at least be a group discussion / decision instead of a unilateral change? Has this been discussed?
There was a problem hiding this comment.
It has not been discussed widely; these changes originally came from the release/v1 branch so I did not realize they would be controversial. I can revert them from this PR for now and open an issue for wider discussion.
Include link to StandardNameRules.rst Co-authored-by: goldy <1588651+gold2718@users.noreply.github.com>
