add author

.zenodo.json

@@ -410,6 +410,11 @@
       "affiliation": "Met Office, UK",
       "name": "Munday, Gregory",
       "orcid": "0000-0003-4750-9923"
+    },
+    {
+      "affiliation": "ACCESS-NRI, Australia",
+      "name": "Chun, Felicity",
+      "orcid": "0009-0007-0845-0953"
     }
   ],
   "description": "ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP.",

CITATION.cff

@@ -421,6 +421,11 @@ authors:
     family-names: Munday
     given-names: Gregory
     orcid: "https://orcid.org/0000-0003-4750-9923"
+  -
+    affiliation: "ACCESS-NRI, Australia"
+    family-names: Chun
+    given-names: Felicity
+    orcid: "https://orcid.org/0009-0007-0845-0953"
 
 cff-version: 1.2.0
 date-released: 2024-07-04

doc/sphinx/source/recipes/recipe_enso_metrics.rst

@@ -61,13 +61,13 @@ Example plots
 -------------
 
 .. _fig_matrix:
-.. figure::  /recipes/figures/<mynewdiagnostic>/plot_matrix_enso.png
+.. figure::  /recipes/figures/enso_metrics/plot_matrix_enso.png
    :align:   center
 
    Add figure caption here.
 
 .. _fig_lifecycle:
-.. figure::  /recipes/figures/<mynewdiagnostic>/ensolifecycle.png
+.. figure::  /recipes/figures/enso_metrics/ensolifecycle.png
    :align:   center
 
    Add figure caption here.

esmvaltool/config-references.yml

@@ -163,6 +163,11 @@ authors:
     name: Chen, Jack
     institute: NCAR, USA
     orcid:
+  chun_felicity:
+    name: Chun, Felicity
+    institute: ACCESS-NRI, Australia
+    orcid: https://orcid.org/0009-0007-0845-0953
+    github: flicj191
   cionni_irene:
     name: Cionni, Irene
     institute: ENEA, Italy

esmvaltool/diag_scripts/enso_metrics/enso_diag1metrics.py

@@ -34,7 +34,7 @@ def plot_level1(input_data, metricval, y_label, title, dtls):
         plt.plot(*input_data[1], label=f'ref: {dtls[1]}', color='black')
         plt.text(0.5, 0.95, f"RMSE: {metricval:.2f}", fontsize=12,
                  ha='center', transform=plt.gca().transAxes,
-                 bbox={'facecolor'='white', 'alpha'=0.8, 'edgecolor'='none'})
+                 bbox=dict(facecolor='white', alpha=0.8, edgecolor='none'))
 
     else:
         plt.scatter(range(len(input_data)), input_data,

esmvaltool/diag_scripts/enso_metrics/matrix.py

@@ -20,12 +20,12 @@ def plot_matrix(diag_path):
     # run normalisation on all these values
     metric_df[2] = (metric_df[2] - metric_df[2].mean()) / metric_df[2].std()
 
-    transformls = []
-    for mod in metric_df[0].unique():  #iterate model, translate metrics
-        mod_df = metric_df.loc[metric_df[0]==mod, :]
-        transformls.append(mod_df[[1, 2]].set_index(1).T.rename(index={2:mod}))
+    t_list = []
+    for mod in metric_df[0].unique():  # iterate model, translate metrics
+        mod_df = metric_df.loc[metric_df[0] == mod, :]
+        t_list.append(mod_df[[1, 2]].set_index(1).T.rename(index={2: mod}))
 
-    matrixdf = pd.concat(transformls)
+    matrixdf = pd.concat(t_list)
     figure = plt.figure(dpi=300)
     plt.imshow(matrixdf, cmap='coolwarm')
     plt.colorbar()