Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pandas #3924

Merged
merged 9 commits into from
Mar 3, 2025
Merged

Unpin pandas #3924

merged 9 commits into from
Mar 3, 2025

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Feb 21, 2025

Description

Continual modernization of our environment, see #3812
Needs ESMValCore=2.12 stable release (can test with RCX if need be)


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@valeriupredoi valeriupredoi added installation requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. labels Feb 21, 2025
@valeriupredoi valeriupredoi added this to the v2.12.0 milestone Feb 21, 2025
@bouweandela
Copy link
Member

Has #3674 been solved?

@valeriupredoi
Copy link
Contributor Author

Has #3674 been solved?

Just as in Ford v Ferrari when Shelby said take her to 7000+ RPM - one way to find out 😁
hq720

@sloosvel
Copy link
Contributor

Hi, the code freeze for version 2.12 will be on Monday 3rd of March. Is this ready to be included? If this is not ready, let me know and I will move it to the next milestone.

@valeriupredoi
Copy link
Contributor Author

yeah! This needs be plopped in 2.12 - @bouweandela pls approve 🍺

@bouweandela
Copy link
Member

If we include this in v2.12, @sloosvel will have to test all the R recipes again. Would you be happy to do that @sloosvel?

@bouweandela
Copy link
Member

Even better, test all the R recipes with this branch before merging because I'm not convinced that #3674 has been solved.

@sloosvel
Copy link
Contributor

Ok, I can have a go at testing the R recipes. I guess I should create a new environment right?

@valeriupredoi
Copy link
Contributor Author

true hero @sloosvel 🎖️ Yeah just the r-base needs be unpinned but I guess we can use the bot here instead of you running them recipes? Well, try a couple, if they need special data the bot doesn't have, then manual rerun should be done

@sloosvel
Copy link
Contributor

I have to admit I am not quite sure how to run the bot 😅 Some of the recipes require quite a big amount of resources anyway, three of the R recipes never finished running during the 2.12 testing despite increasing the time limit of the jobs... For the moment I am creating a new environment which is taking forever to solve.

@valeriupredoi
Copy link
Contributor Author

just as the Circle test https://app.circleci.com/pipelines/github/ESMValGroup/ESMValTool/13797/workflows/21f50cc0-95cc-4959-9731-80f01f87b1c6/jobs/80790 - the problem is that unpinning these two may actually be very harsh on our already hard to solve env - let me pop in a GHA see the times

@sloosvel
Copy link
Contributor

It's been two hours and it's still solving for me...

@valeriupredoi
Copy link
Contributor Author

yeah that's not promising at all, lemme have a look at what the GHA does

@valeriupredoi
Copy link
Contributor Author

@sloosvel the GHA tests run fine and envs get solves in 2-4min - make sure you are using mamba=2+, otherwise with an older mamba things get veeery slow

@sloosvel
Copy link
Contributor

I upgraded mamba:

[b381943@levante1 ~]$ mamba --version
2.0.5

But it still gets stuck solving the environment, the loading bar does not even move. I'll try over the weekend and let's see what happens

@valeriupredoi
Copy link
Contributor Author

don't make it a priority, Saskia, it's good to have the pin on pandas removed, but the one on r-base doesn't matter that much, it's not a massive blocker against anything. The big blocker is NCL anyway. Have a good weekend, don't work 🍺

@sloosvel
Copy link
Contributor

sloosvel commented Mar 3, 2025

The following R recipes fail using this branch:

  • recipe_combined_indices.yml
  • recipe_extreme_events.yml
  • recipe_miles_block.yml
  • recipe_miles_eof.yml
  • recipe_miles_regimes.yml
  • recipe_quantilebias.yml

@valeriupredoi
Copy link
Contributor Author

Thanks, Saskia! Is there any R recipe that runs fine? 🤣
Ok, let's keep the r-base pin for now then, and only unpin 🐼

@sloosvel sloosvel changed the title Unpin pandas and r-base Unpin pandas Mar 3, 2025
@sloosvel sloosvel merged commit a8f929c into main Mar 3, 2025
8 checks passed
@sloosvel sloosvel deleted the unpin_pandas_rbase branch March 3, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants