-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin pandas #3924
Unpin pandas #3924
Conversation
Has #3674 been solved? |
Just as in Ford v Ferrari when Shelby said take her to 7000+ RPM - one way to find out 😁 |
Hi, the code freeze for version 2.12 will be on Monday 3rd of March. Is this ready to be included? If this is not ready, let me know and I will move it to the next milestone. |
yeah! This needs be plopped in 2.12 - @bouweandela pls approve 🍺 |
Even better, test all the R recipes with this branch before merging because I'm not convinced that #3674 has been solved. |
Ok, I can have a go at testing the R recipes. I guess I should create a new environment right? |
true hero @sloosvel 🎖️ Yeah just the r-base needs be unpinned but I guess we can use the bot here instead of you running them recipes? Well, try a couple, if they need special data the bot doesn't have, then manual rerun should be done |
I have to admit I am not quite sure how to run the bot 😅 Some of the recipes require quite a big amount of resources anyway, three of the R recipes never finished running during the 2.12 testing despite increasing the time limit of the jobs... For the moment I am creating a new environment which is taking forever to solve. |
just as the Circle test https://app.circleci.com/pipelines/github/ESMValGroup/ESMValTool/13797/workflows/21f50cc0-95cc-4959-9731-80f01f87b1c6/jobs/80790 - the problem is that unpinning these two may actually be very harsh on our already hard to solve env - let me pop in a GHA see the times |
It's been two hours and it's still solving for me... |
yeah that's not promising at all, lemme have a look at what the GHA does |
@sloosvel the GHA tests run fine and envs get solves in 2-4min - make sure you are using mamba=2+, otherwise with an older mamba things get veeery slow |
I upgraded mamba:
But it still gets stuck solving the environment, the loading bar does not even move. I'll try over the weekend and let's see what happens |
don't make it a priority, Saskia, it's good to have the pin on pandas removed, but the one on r-base doesn't matter that much, it's not a massive blocker against anything. The big blocker is NCL anyway. Have a good weekend, don't work 🍺 |
The following R recipes fail using this branch:
|
Thanks, Saskia! Is there any R recipe that runs fine? 🤣 |
Description
Continual modernization of our environment, see #3812
Needs ESMValCore=2.12 stable release (can test with RCX if need be)
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.