Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node list to the SCORE to alfacase converter #5

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

gabrielantao
Copy link
Contributor

@gabrielantao gabrielantao commented Jul 1, 2024

I this PR I did the build of the nodes data with some default values. Also did moved the enums previously in reader to the common module.

PWPA-1977

Move enums to common.py;
Add curve to the prepare_for_regression function;

PWPA-1977
@gabrielantao gabrielantao force-pushed the fb-PWPA-1977-convert-nodes-score-converter branch from 23d1561 to 708ce18 Compare July 1, 2024 16:20
Redo the comment for annulus task;

PWPA-1977
@gabrielantao gabrielantao requested a review from carlosnewmar July 2, 2024 14:51
Copy link

sonarqubecloud bot commented Jul 2, 2024

Copy link
Contributor

@carlosnewmar carlosnewmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@gabrielantao gabrielantao merged commit 9d67bec into master Jul 2, 2024
14 checks passed
@gabrielantao gabrielantao deleted the fb-PWPA-1977-convert-nodes-score-converter branch July 2, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants