Add Dotpay CHk Parameter support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grevin
force-pushed
the
add-dotpoy-chk-parameter-support
branch
from
6f49d4a to
1cc4a80
Compare
nicolas-grevin
commented
Apr 17, 2019
| * | ||
| * @return mixed Method return. | ||
| */ | ||
| private function invokeMethod(&$object, $methodName, array $parameters = array()) |
There was a problem hiding this comment.
Or i change generateChk and generateRecipientChk to public function
ch3ric
requested changes
Apr 17, 2019
nicolas-grevin
force-pushed
the
add-dotpoy-chk-parameter-support
branch
from
b0611fb to
9bee883
Compare
nicolas-grevin
commented
Apr 18, 2019
| @@ -36,3 +36,5 @@ Routing | |||
| //YAML routing.yml | |||
| ets_payment_dotpay_bundle: | |||
| resource: "@ETSPaymentDotpayBundle/Resources/config/routing.yml" | |||
|
|
|||
| .. _JMSPaymentCoreBundle: https://github.com/schmittjoh/JMSPaymentCoreBundle/blob/master/Resources/doc/index.rst | |||
There was a problem hiding this comment.
graillus
reviewed
Apr 18, 2019
ch3ric
reviewed
Apr 18, 2019
graillus
approved these changes
Apr 18, 2019
ch3ric
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is new #3