Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to IC generation routines in utils/ICs #107

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

The9Cat
Copy link
Contributor

@The9Cat The9Cat commented Jan 23, 2025

Summary of changes

  • Added a new routine, addring to generate a phase-space torus of material with a Gaussian velocity dispersion given a spherical halo model
  • Fixed an error in the AxiSymModel:gen_point routine for particles at a given radius. This was not previously used by gensph.
  • Updated AxiSymModel::gen_point routines to support new quiet-start methods implemented in gensph. These include distributing particles on a spherical position 'grid', distributing particles on a spherical position and velocity grid, Sellwood's quiet-start orbital plane algorithm, the same algorithm where orbital planes are simultaneously distributed on the sphere using a Fibonacci sequence
  • Updated internal code in the model realization routines to use const values for algorithm constants rather than preprocessor values.

Comments

None of these changes affect existing EXP or pyEXP behavior. Perhaps addring might be dropped from this PR as too specific and idiosyncratic?

@michael-petersen
Copy link
Member

All changes look good here -- but do we want to wait and do all IC updates simultaneously? Or we can merge this and start a new PR.

@The9Cat
Copy link
Contributor Author

The9Cat commented Feb 7, 2025

Maybe it's cleaner to add the gendisk quiet-start changes to this PR? The only advantage to merging now is the availability of the gensph quieter start. So do you want/need that any time soon? These things are rather specialized. E.g. the IC relaxation typically used for disk + halo will wipe out the quiet-start advantage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants