-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to IC generation routines in utils/ICs
#107
base: main
Are you sure you want to change the base?
Conversation
…dernized the gen_point API
All changes look good here -- but do we want to wait and do all IC updates simultaneously? Or we can merge this and start a new PR. |
Maybe it's cleaner to add the |
Summary of changes
addring
to generate a phase-space torus of material with a Gaussian velocity dispersion given a spherical halo modelAxiSymModel:gen_point
routine for particles at a given radius. This was not previously used bygensph
.AxiSymModel::gen_point
routines to support new quiet-start methods implemented ingensph
. These include distributing particles on a spherical position 'grid', distributing particles on a spherical position and velocity grid, Sellwood's quiet-start orbital plane algorithm, the same algorithm where orbital planes are simultaneously distributed on the sphere using a Fibonacci sequenceconst
values for algorithm constants rather than preprocessor values.Comments
None of these changes affect existing
EXP
orpyEXP
behavior. Perhapsaddring
might be dropped from this PR as too specific and idiosyncratic?