added: IExpressionToCode interface with ToCode methods and full range of... #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of ToCode expression methods. added: Rules for specifying FullTypeNames and ExplicitMethodTypeArgs. fixed: #13 Explicit type parameters for methods omitted - Instead of inferring which is complex task, I want to have setting to turn it on for my use case, and be off by default.
|
Found issues mainly with |
|
This is exactly the direction I'd hope this lib would go, so thanks for the contrib! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added: IExpressionToCode interface with ToCode method and full range of ToCode extension methods.
added: Rules for specifying FullTypeNames and ExplicitMethodTypeArgs.
fixed: #13 Explicit type parameters for methods omitted - Instead of inferring which is complex task, I want to have setting to turn it on for my use case, and be off by default.
Hello,
I made change towards non-static ExpressionToCode. It is incomplete because I did not touch AnnotatedToCode. I want to hear you feedback first on this approach.
The reason in the first place was to support two use cases: with Type.FullName instead of just name, and the one related to #13 .
Hope it is right direction,
Maksim