This repository has been archived by the owner on May 7, 2021. It is now read-only.
Physical and network distance calculation #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to destination id in the connection list
alyhasansakr
suggested changes
Feb 22, 2021
There was a problem hiding this comment.
Remove all the unnecessary spaces and tabs.
In general I dislike the way we implement the getters for the Network class. You should be able to index through the lists rather than doing a linear search every time a piece of information is needed. Each instance (device, location and so on) must have a unique ID and thus could be indexed (normally using a HashMap).
src/main/java/InfrastructureManager/Modules/NetworkStructure/NetworkModule.java
Outdated
Show resolved
Hide resolved
src/main/java/InfrastructureManager/Modules/NetworkStructure/Input/LocationInput.java
Outdated
Show resolved
Hide resolved
src/main/java/InfrastructureManager/Modules/NetworkStructure/Network.java
Outdated
Show resolved
Hide resolved
src/main/java/InfrastructureManager/Modules/NetworkStructure/Network.java
Outdated
Show resolved
Hide resolved
| * Function to get network distance between devices or between application instances. | ||
| * @param sourceId and destinationId | ||
| */ | ||
| public double getNetworkDistance(String sourceId, String destinationId) { |
There was a problem hiding this comment.
It would have helped me a lot if you had some explanation written of how this is supposed to provide the network distance. I don't understand how it works?
src/main/java/InfrastructureManager/Modules/NetworkStructure/NetworkModuleObject.java
Outdated
Show resolved
Hide resolved
src/main/java/InfrastructureManager/Modules/NetworkStructure/Output/DistanceOutput.java
Outdated
Show resolved
Hide resolved
| double distance =this.network.getphysicalDistanceBetweenApplications(commandLine[2],commandLine[3]); | ||
| this.getSharedDistance().putValuetoQueue(distance); | ||
| } | ||
| case "get_network_distance" -> { |
There was a problem hiding this comment.
Network distance could also be for devices and applications.
src/main/java/InfrastructureManager/Modules/NetworkStructure/Output/LocationOutput.java
Outdated
Show resolved
Hide resolved
src/main/java/InfrastructureManager/Modules/NetworkStructure/Shared/SharedDistance.java
Outdated
Show resolved
Hide resolved
…read write with maps
Tried to convert the Network Object to JSON file but unable to.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Physical distance calculation computation
Get location of a device or application instance implemented
Modified few getter functions in network class
Network distance draft implementation
Pending:
network distance computation.
input and output module functions