Remove-once-frequency

[EduardSchwarzkopf]

Summary by Sourcery

Remove the 'ONCE' frequency option from both the codebase and the database, including updating the relevant function logic and adding a migration script.

Enhancements:

• Remove the 'ONCE' frequency option from the Frequency enum in the codebase.

Deployment:

• Add a new Alembic migration script to remove the 'ONCE' frequency from the database.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes the 'ONCE' frequency option from the application. The changes include updating the Frequency enum, modifying the logic for handling scheduled transactions, and adding a database migration to remove the 'once' frequency from the database.

File-Level Changes

Files	Changes
app/utils/enums.py	Removed 'ONCE' from the Frequency enum
app/repository.py	Updated the get_period_start_date function to remove the case for Frequency.ONCE
alembic/versions/9694a1dffec2_remove_frequency_once_from_database.py	Added a new Alembic migration to remove the 'once' frequency from the database

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @EduardSchwarzkopf - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider implementing a downgrade function in the migration file to make this change reversible if needed.
• Ensure that all parts of the system that might have used the 'ONCE' frequency have been updated and tested thoroughly to prevent any potential breaks in functionality.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟡 Security: 1 issue found
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

🚨 suggestion (security): Use parameterized queries instead of f-strings for SQL execution

While f-strings work here, it's safer to use parameterized queries to prevent potential SQL injection vulnerabilities. Consider using SQLAlchemy's text() function with bind parameters for this operation.

Suggested change

	op.execute(f" DELETE FROM {Frequency.__tablename__} WHERE label = 'once'")
	from sqlalchemy import text
	from app.models import Frequency
	op.execute(
	text("DELETE FROM :table WHERE label = :label"),
	{"table": Frequency.__tablename__, "label": "once"}
	)