Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary as in all function in the Effect Either module #4574

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

giuliobracci
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Removed unnecessary as in all function from the Either module. Currently the input is correctly inferred by the compiler as an Iterable<Either<any, any>>. I believe the as in this case was a leftover of a previous implementation.

I also tried to remove the @ts-expect-error at the start of the function, but I did not manage to fix the type error.

Related

  • Related Issue #
  • Closes #

Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 4d2d7da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gcanti gcanti merged commit a2361c6 into Effect-TS:main Mar 10, 2025
11 checks passed
@giuliobracci
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants