Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nixpkgs and add --developer flag to cln test config #263

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

grubles
Copy link
Collaborator

@grubles grubles commented Dec 19, 2023

Bumps daemons to the following:

cln v23.11.1
lnd v0.17.0-beta
bitcoin v25.1
elements v23.2.1

Also adds --developer flag to the testframework CLN config since --enable-developer is removed in the latest CLN.

Fixes #249

@grubles
Copy link
Collaborator Author

grubles commented Jan 1, 2024

clightning-1: 2023-12-19T23:33:27.951Z DEBUG   plugin-manager: started(56618) /home/runner/work/peerswap/peerswap/out/test-builds/peerswap
clightning-1: 2023-12-19T23:33:28.071Z INFO    plugin-peerswap: PeerSwap starting up with commit 87e75a203649be5dc543af4d6ff9897075060fc8
2023-12-19T23:33:28.071Z INFO    plugin-peerswap: DB version: v0.2, Protocol version: 3
2023-12-19T23:33:28.071Z INFO    plugin-peerswap: Dev-mode enabled.
2023-12-19T23:33:28.071Z INFO    plugin-peerswap: Using data dir: /run/user/1001/Test_LndCln_Bitcoin_SwapInclaim_coop2336898124/001/clightning-EqKGu/regtest
clightning-1: 2023-12-19T23:33:28.074Z INFO    plugin-peerswap: Could not read from bitcoin cookie: /home/runner/.bitcoin/regtest/.cookie
2023-12-19T23:33:28.074Z INFO    plugin-peerswap: Could not read from elements cookie: /home/runner/.elements/liquidregtest/.cookie
clightning-1: 2023-12-19T23:33:28.077Z INFO    plugin-peerswap: WARNING: allow-deprecated-apis=false detected in CLN config. Exiting. More info: https://github.com/ElementsProject/peerswap/issues/232
clightning-1: 2023-12-19T23:33:29.077Z INFO    plugin-peerswap: Killing plugin: exited during normal operation

CLN plugin appears to exit early in the tests because --developer turns off deprecated APIs.

@grubles
Copy link
Collaborator Author

grubles commented Jan 8, 2024

Ok this is failing because latest CLN defaults to enabling large channels and ignores the wumbo/large-channels config options, which makes PeerSwap think the config option is not enabled.

=== CONT  Test_Wumbo/out_lc_max+
    wumbo_test.go:205: 
        	Error Trace:	/home/runner/work/peerswap/peerswap/test/wumbo_test.go:205
        	Error:      	Received unexpected error:
        	            	-1:swap amount is 4294968000: need to enable option '--large-channels' to swap amounts larger than 2^32 msat
        	Test:       	Test_Wumbo/out_lc_max+

Copy link
Contributor

@YusukeShimizu YusukeShimizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.
I will be running the Test_ClnCln_StuckChannels test again with #271.

@grubles grubles merged commit 6bd3af1 into ElementsProject:master Jan 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLN drops developer configure flag
2 participants